Skip to content

Add LINSTOR controller and satellite helpers - #22

Open
Wescoeur wants to merge 14 commits into
ran-rpc-module-drbdfrom
ran-linstor-controller-satellites-helpers
Open

Wescoeur wants to merge 14 commits into
ran-rpc-module-drbdfrom
ran-linstor-controller-satellites-helpers

Conversation

@Wescoeur

@Wescoeur Wescoeur commented Oct 7, 2026

Copy link
Copy Markdown
Member

Must be merged after #11.

@Wescoeur
Wescoeur requested a review from a team October 7, 2026 21:24
@Wescoeur Wescoeur changed the title Ran linstor controller satellites helpers Add LINSTOR controller and satellite helpers Oct 7, 2026
@Wescoeur
Wescoeur force-pushed the ran-linstor-controller-satellites-helpers branch from 669ccf7 to e14a89d Compare October 7, 2026 21:26
Wescoeur added a commit that referenced this pull request Oct 7, 2026
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur added a commit that referenced this pull request Oct 7, 2026
Executables were run through hardcoded absolute paths, it only works on some distributions.
`ss` is in `/usr/bin` on the GitHub Ubuntu runners, instead of in `/usr/sbin`
on XCP-ng so the LINSTOR controller tests are marked as failed.

Now "/etc/os-release" is used to find alternate OS specific paths instead.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
@Wescoeur
Wescoeur force-pushed the ran-linstor-controller-satellites-helpers branch from e14a89d to fbe8a4f Compare October 7, 2026 21:28
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Before this fix, this test was unstable and could fail.
It's wiser to wait for the server to close instead of spamming calls.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
The goal of this change is to continue retrying calls in the event
of network loss, while also allowing this feature to be disabled
for calls that are not idempotent and require more intelligence
on the caller side.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Without that we can trigger this error:
```
> mypy
tests/rpc/conftest.py: error: Duplicate module named "conftest" (also at "tests/backends/conftest.py")
tests/rpc/conftest.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info
tests/rpc/conftest.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH
Found 1 error in 1 file (errors prevented further checking)
```

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
@Wescoeur
Wescoeur force-pushed the ran-rpc-module-drbd branch from 3fa2ea1 to 0e6a1cc Compare October 7, 2026 23:31
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Executables were run through hardcoded absolute paths, it only works on some distributions.
`ss` is in `/usr/bin` on the GitHub Ubuntu runners, instead of in `/usr/sbin`
on XCP-ng so the LINSTOR controller tests are marked as failed.

Now "/etc/os-release" is used to find alternate OS specific paths instead.

Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
@Wescoeur
Wescoeur force-pushed the ran-linstor-controller-satellites-helpers branch from fbe8a4f to abf7a3d Compare October 7, 2026 23:31
@Wescoeur
Wescoeur force-pushed the ran-rpc-module-drbd branch from 0e6a1cc to 163d524 Compare October 11, 2026 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant