Repository navigation
Conversation
Wescoeur
force-pushed
the
ran-linstor-controller-satellites-helpers
branch
from
October 7, 2026 21:26
669ccf7 to
e14a89d
Compare
Wescoeur
added a commit
that referenced
this pull request
Oct 7, 2026
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
added a commit
that referenced
this pull request
Oct 7, 2026
Executables were run through hardcoded absolute paths, it only works on some distributions. `ss` is in `/usr/bin` on the GitHub Ubuntu runners, instead of in `/usr/sbin` on XCP-ng so the LINSTOR controller tests are marked as failed. Now "/etc/os-release" is used to find alternate OS specific paths instead. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
force-pushed
the
ran-linstor-controller-satellites-helpers
branch
from
October 7, 2026 21:28
e14a89d to
fbe8a4f
Compare
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Before this fix, this test was unstable and could fail. It's wiser to wait for the server to close instead of spamming calls. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
The goal of this change is to continue retrying calls in the event of network loss, while also allowing this feature to be disabled for calls that are not idempotent and require more intelligence on the caller side. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Without that we can trigger this error: ``` > mypy tests/rpc/conftest.py: error: Duplicate module named "conftest" (also at "tests/backends/conftest.py") tests/rpc/conftest.py: note: See https://mypy.readthedocs.io/en/stable/running_mypy.html#mapping-file-paths-to-modules for more info tests/rpc/conftest.py: note: Common resolutions include: a) using `--exclude` to avoid checking one of them, b) adding `__init__.py` somewhere, c) using `--explicit-package-bases` or adjusting MYPYPATH Found 1 error in 1 file (errors prevented further checking) ``` Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
force-pushed
the
ran-rpc-module-drbd
branch
from
October 7, 2026 23:31
3fa2ea1 to
0e6a1cc
Compare
Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Executables were run through hardcoded absolute paths, it only works on some distributions. `ss` is in `/usr/bin` on the GitHub Ubuntu runners, instead of in `/usr/sbin` on XCP-ng so the LINSTOR controller tests are marked as failed. Now "/etc/os-release" is used to find alternate OS specific paths instead. Signed-off-by: Ronan Abhamon <ronan.abhamon@vates.tech>
Wescoeur
force-pushed
the
ran-linstor-controller-satellites-helpers
branch
from
October 7, 2026 23:31
fbe8a4f to
abf7a3d
Compare
Wescoeur
force-pushed
the
ran-rpc-module-drbd
branch
from
October 11, 2026 11:54
0e6a1cc to
163d524
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Must be merged after #11.